fix(plugin-eslint): replace static @nx/devkit import by matejchalk · Pull Request #1185 · code-pushup/cli

matejchalk · 2025-12-11T16:56:30Z

Fixes a bug introduced by wrong logger import (IDE autofilled @nx/devkit instead of @code-pushup/utils) in #1176. This causes the ESLint plugin to fail in non-Nx repos, e.g., here.

To prevent this mistake from reocurring, I added the no-restricted-imports rule to our ESLint config.

Finally, I noticed that changes to our root eslint.config.js didn't invalidate lint target cache, so I adjusted our Nx cache configuration.

nx-cloud · 2025-12-11T16:57:54Z

View your CI Pipeline Execution ↗ for commit c389aa1

Command	Status	Duration	Result
`nx run-many -t unit-test,int-test`	✅ Succeeded	1m 56s	View ↗

☁️ Nx Cloud last updated this comment at 2025-12-11 17:31:47 UTC

pkg-pr-new · 2025-12-11T16:58:06Z

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1185

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1185

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1185

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1185

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1185

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1185

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1185

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1185

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1185

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1185

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1185

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1185

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1185

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1185

commit: c389aa1

github-actions · 2025-12-11T17:11:34Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 54f73db with previous commit 0cf7d2a.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
SEO	🟡 85	🟢 92
Best Practices	🟢 97	🟢 100
Performance	🔴 41	🔴 44
Axe Accessibility	🟢 90	🟡 88
Accessibility	🟢 91	🟢 92
Code coverage	🟡 89	🟡 89
Code style	🟢 99	🟢 99
Bug prevention	🟡 67	🟡 67	–
Security	🔴 43	🔴 43	–
Updates	🟡 71	🟡 71	–
Type Safety	🟡 56	🟡 56	–
Miscellaneous	🟡 67	🟡 67	–
Documentation	🔴 35	🔴 35	–

👍 7 groups improved, 👎 4 groups regressed, 👍 9 audits improved, 👎 6 audits regressed, 42 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score
Axe Accessibility	Semantics	🟢 100	🟡 50
Axe Accessibility	Keyboard	🟡 75	🟢 100
Axe Accessibility	Language	🟡 75	🟢 100
Axe Accessibility	Tables	🟢 100	🟡 75
Lighthouse	SEO	🟡 85	🟢 92
Axe Accessibility	ARIA	🟢 100	🟢 95
Lighthouse	Best Practices	🟢 97	🟢 100
Lighthouse	Performance	🔴 41	🔴 44
Lighthouse	Accessibility	🟢 91	🟢 92
Code coverage	Code coverage metrics	🟡 89	🟡 89
ESLint	Suggestions	🟢 99	🟢 99

23 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Axe Accessibility	ARIA attributes must conform to valid values	🟩 0 elements	🟥 8 errors
Axe Accessibility	Elements must have their visible text as part of their accessible name	🟩 0 elements	🟥 2 errors
Lighthouse	No browser errors logged to the console	🟥 failed	🟩 passed
Lighthouse	Elements use only permitted ARIA attributes	🟥 failed	🟩 passed
Lighthouse	robots.txt is valid	🟥 failed	🟩 passed
Axe Accessibility	Table headers in a data table must refer to data cells	🟩 0 elements	🟥 1 error
Axe Accessibility	Page must have means to bypass repeated blocks	🟥 1 error	🟩 1 element
Axe Accessibility	`<html>` element must have a lang attribute	🟥 1 error	🟩 1 element
Lighthouse	Enable text compression	🟨 Potential savings of 29 KiB	🟩 0
Lighthouse	First Contentful Paint	🟥 5.6 s	🟥 3.3 s
Lighthouse	Speed Index	🟥 6.7 s	🟥 5.9 s
Lighthouse	Max Potential First Input Delay	🟥 430 ms	🟥 550 ms
Lighthouse	Time to Interactive	🟥 14.7 s	🟥 12.3 s
Lighthouse	Total Blocking Time	🟥 720 ms	🟥 840 ms
Code coverage	Branch coverage	🟨 87.1 %	🟨 87.1 %
Lighthouse	Avoids enormous network payloads	🟩 Total size was 2,206 KiB	🟩 Total size was 2,059 KiB
Lighthouse	Uses efficient cache policy on static assets	🟨 15 resources found	🟨 30 resources found
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	Server Backend Latencies	🟩 2,560 ms	🟩 1,430 ms
Lighthouse	Minimizes main-thread work	🟥 7.2 s	🟥 6.3 s
Lighthouse	JavaScript execution time	🟥 2.0 s	🟥 2.4 s
Lighthouse	Largest Contentful Paint	🟥 11.5 s	🟥 11.3 s
Axe Accessibility	ARIA hidden element must not be focusable or contain focusable elements	🟩 0 elements	🟩 200 elements
Lighthouse	Reduce unused CSS	🟥 Potential savings of 94 KiB	🟥 Potential savings of 94 KiB
Axe Accessibility	Elements must only use supported ARIA attributes	🟩 0 elements	🟩 99 elements
Axe Accessibility	ARIA attributes must be used as specified for the element's role	🟩 0 elements	🟩 99 elements
Axe Accessibility	Elements must only use permitted ARIA attributes	🟩 0 elements	🟩 99 elements
Axe Accessibility	ARIA attributes must conform to valid names	🟩 0 elements	🟩 99 elements
Axe Accessibility	`<li>` elements must be contained in a `<ul>` or `<ol>`	🟩 0 elements	🟩 65 elements
Lighthouse	Reduce unused JavaScript	🟥 Potential savings of 187 KiB	🟥 Potential savings of 187 KiB
Axe Accessibility	Interactive controls must not be nested	🟩 1 element	🟩 59 elements
Lighthouse	Remove duplicate modules in JavaScript bundles	🟥 Potential savings of 104 KiB	🟥 Potential savings of 100 KiB
Lighthouse	Initial server response time was short	🟥 Root document took 670 ms	🟥 Root document took 630 ms
Axe Accessibility	Inline text spacing must be adjustable with custom stylesheets	🟩 0 elements	🟩 41 elements
Axe Accessibility	IDs used in ARIA and labels must be unique	🟩 0 elements	🟩 28 elements
Lighthouse	Network Round Trip Times	🟩 50 ms	🟩 70 ms
Axe Accessibility	Buttons must have discernible text	🟩 0 elements	🟩 13 elements
Axe Accessibility	`<ul>` and `<ol>` must only directly contain `<li>`, `<script>` or `<template>` elements	🟩 0 elements	🟩 13 elements
Axe Accessibility	Links must be distinguishable without relying on color	🟩 0 elements	🟩 7 elements
Axe Accessibility	Deprecated ARIA roles must not be used	🟩 0 elements	🟩 6 elements
Axe Accessibility	Required ARIA attributes must be provided	🟩 0 elements	🟩 6 elements
Axe Accessibility	ARIA roles used must conform to valid values	🟩 0 elements	🟩 6 elements
Axe Accessibility	Images must have alternative text	🟥 1 error	🟥 6 errors
Axe Accessibility	Links must have discernible text	🟥 1 error	🟥 6 errors
Axe Accessibility	Data or header cells must not be used to give caption to a data table.	🟩 0 elements	🟩 4 elements
Axe Accessibility	Table cell headers attributes must refer to other `<th>` elements in the same table	🟩 0 elements	🟩 4 elements
Lighthouse	Avoids an excessive DOM size	🟥 2,354 elements	🟥 2,357 elements
Axe Accessibility	Elements must meet minimum color contrast ratio thresholds	🟥 3 errors	🟥 5 errors
Axe Accessibility	Non-empty `<td>` elements in larger `<table>` must have an associated table header	🟩 0 elements	🟩 2 elements
Axe Accessibility	Certain ARIA roles must contain particular children	🟩 0 elements	🟩 1 element
Axe Accessibility	Form field must not have multiple label elements	🟩 0 elements	🟩 1 element
Axe Accessibility	`<html>` element must have a valid value for the lang attribute	🟩 0 elements	🟩 1 element
Axe Accessibility	Form elements must have labels	🟩 0 elements	🟩 1 element
Axe Accessibility	Zooming and scaling must not be disabled	🟩 0 elements	🟩 1 element
Axe Accessibility	Styled `<p>` elements must not be used as headings	🟩 1 element	🟩 2 elements
Code coverage	Line coverage	🟨 84.8 %	🟨 84.8 %
Lighthouse	Cumulative Layout Shift	🟩 0	🟩 0